SET ANSI_NULLS ON; GO SET QUOTED_IDENTIFIER ON; GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'Description' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'Description' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'Description' , N'SCHEMA',N'dbo', N'TYPE',N'SizeOptimiserTableType', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'Description' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'TYPE',@level1name=N'SizeOptimiserTableType'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@SqlMinorVersion' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@SqlMinorVersion' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@SqlMajorVersion' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@SqlMajorVersion' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@IndexNumThreshold' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@IndexNumThreshold' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@IncludeDatabases' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@IncludeDatabases' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@ExcludeDatabases' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@ExcludeDatabases' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@IncludeSysDatabases' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@IncludeSysDatabases' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@IncludeSSRSDatabases' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@IncludeSSRSDatabases' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@Verbose' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@Verbose' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO IF EXISTS (SELECT * FROM sys.fn_listextendedproperty(N'@IsExpress' , N'SCHEMA',N'dbo', N'PROCEDURE',N'sp_sizeoptimiser', NULL,NULL)) BEGIN; EXEC sys.sp_dropextendedproperty @name=N'@IsExpress' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; END GO /******************************/ /* Cleanup existing versions */ /******************************/ IF EXISTS (SELECT * FROM sys.objects WHERE object_id = OBJECT_ID(N'[dbo].[sp_sizeoptimiser]')) BEGIN DROP PROCEDURE [dbo].[sp_sizeoptimiser]; END; IF EXISTS (SELECT * FROM sys.types st JOIN sys.schemas ss ON st.schema_id = ss.schema_id WHERE st.name = N'SizeOptimiserTableType' AND ss.name = N'dbo') BEGIN DROP TYPE [dbo].[SizeOptimiserTableType]; END; GO /**************************************************************/ /* Create user defined table type for database list parameter */ /**************************************************************/ IF NOT EXISTS (SELECT * FROM sys.types st JOIN sys.schemas ss ON st.schema_id = ss.schema_id WHERE st.name = N'SizeOptimiserTableType' AND ss.name = N'dbo') BEGIN CREATE TYPE [dbo].[SizeOptimiserTableType] AS TABLE( [database_name] [sysname] NOT NULL, PRIMARY KEY CLUSTERED ([database_name] ASC) WITH (IGNORE_DUP_KEY = OFF)); END; GO /***************************/ /* Create stored procedure */ /***************************/ IF NOT EXISTS(SELECT * FROM sys.objects WHERE object_id = OBJECT_ID(N'[dbo].[sp_sizeoptimiser]')) BEGIN EXEC dbo.sp_executesql @statement = N'CREATE PROCEDURE [dbo].[sp_sizeoptimiser] AS'; END; GO ALTER PROCEDURE [dbo].[sp_sizeoptimiser] @IndexNumThreshold SMALLINT = 10 ,@IncludeDatabases [dbo].[SizeOptimiserTableType] READONLY ,@ExcludeDatabases [dbo].[SizeOptimiserTableType] READONLY ,@IncludeSysDatabases BIT = 0 ,@IncludeSSRSDatabases BIT = 0 ,@Verbose BIT = 1 /* Parameters defined here for testing only */ ,@IsExpress BIT = NULL ,@SqlMajorVersion TINYINT = NULL ,@SqlMinorVersion SMALLINT = NULL WITH RECOMPILE AS /* sp_sizeoptimiser - Recommends space saving measures for data footprints. Part of the DBA MultiTool http://dba-multitool.org Version: 20201110 MIT License Copyright (c) 2020 John McCall Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. ========= Example: DECLARE @include SizeOptimiserTableType; INSERT INTO @include ([database_name]) VALUES (N'WideWorldImporters'); EXEC [dbo].[sp_sizeoptimiser] @IncludeDatabases = @include */ BEGIN SET NOCOUNT ON; BEGIN TRY DECLARE @HasTempStat BIT = 0 ,@HasPersistedSamplePercent BIT = 0 ,@CheckNumber TINYINT = 0 ,@EngineEdition TINYINT ,@CheckSQL NVARCHAR(MAX) = N'' ,@Msg NVARCHAR(MAX) = N'' ,@DbName SYSNAME = N'' ,@TempCheckSQL NVARCHAR(MAX) = N'' ,@BaseURL VARCHAR(1000) = 'http://dba-multitool.org/'; /* Validate @IndexNumThreshold */ IF (@IndexNumThreshold < 1 OR @IndexNumThreshold > 999) BEGIN SET @Msg = '@IndexNumThreshold must be between 1 and 999.'; RAISERROR(@Msg, 16, 1); END /* Validate database list */ IF (SELECT COUNT(*) FROM @IncludeDatabases) >= 1 AND (SELECT COUNT(*) FROM @ExcludeDatabases) >= 1 BEGIN SET @Msg = 'Both @IncludeDatabases and @ExcludeDatabases cannot be specified.'; RAISERROR(@Msg, 16, 1); END CREATE TABLE #Databases ( [database_name] SYSNAME NOT NULL); /* Build database list if no parameters set */ IF (SELECT COUNT(*) FROM @IncludeDatabases) = 0 AND (SELECT COUNT(*) FROM @ExcludeDatabases) = 0 BEGIN INSERT INTO #Databases SELECT [sd].[name] FROM [sys].[databases] AS [sd] WHERE ([sd].[database_id] > 4 OR @IncludeSysDatabases = 1) AND ([sd].[name] NOT IN ('ReportServer', 'ReportServerTempDB') OR @IncludeSSRSDatabases = 1) AND DATABASEPROPERTYEX([sd].[name], 'UPDATEABILITY') = N'READ_WRITE' AND DATABASEPROPERTYEX([sd].[name], 'USERACCESS') = N'MULTI_USER' AND DATABASEPROPERTYEX([sd].[name], 'STATUS') = N'ONLINE'; END; /* Build database list from @IncludeDatabases */ ELSE IF (SELECT COUNT(*) FROM @IncludeDatabases) >= 1 BEGIN INSERT INTO #Databases SELECT [sd].[name] FROM @IncludeDatabases AS [d] INNER JOIN [sys].[databases] AS [sd] ON [sd].[name] COLLATE database_default = REPLACE(REPLACE([d].[database_name], '[', ''), ']', '') WHERE DATABASEPROPERTYEX([sd].[name], 'UPDATEABILITY') = N'READ_WRITE' AND DATABASEPROPERTYEX([sd].[name], 'USERACCESS') = N'MULTI_USER' AND DATABASEPROPERTYEX([sd].[name], 'STATUS') = N'ONLINE'; IF (SELECT COUNT(*) FROM @IncludeDatabases) > (SELECT COUNT(*) FROM #Databases) BEGIN DECLARE @ErrorDatabaseList NVARCHAR(MAX); WITH ErrorDatabase AS( SELECT [database_name] FROM @IncludeDatabases EXCEPT SELECT [database_name] FROM #Databases) SELECT @ErrorDatabaseList = ISNULL(@ErrorDatabaseList + N', ' + [database_name], [database_name]) FROM ErrorDatabase; SET @Msg = 'Supplied databases do not exist or are not accessible: ' + @ErrorDatabaseList + '.'; RAISERROR(@Msg, 16, 1); END; END; /* Build database list from @ExcludeDatabases */ ELSE IF (SELECT COUNT(*) FROM @ExcludeDatabases) >= 1 BEGIN INSERT INTO #Databases SELECT [sd].[name] FROM [sys].[databases] AS [sd] WHERE NOT EXISTS (SELECT [d].[database_name] FROM @IncludeDatabases AS [d] WHERE [sd].[name] COLLATE database_default = REPLACE(REPLACE([d].[database_name], '[', ''), ']', '')) AND DATABASEPROPERTYEX([sd].[name], 'UPDATEABILITY') = N'READ_WRITE' AND DATABASEPROPERTYEX([sd].[name], 'USERACCESS') = N'MULTI_USER' AND DATABASEPROPERTYEX([sd].[name], 'STATUS') = N'ONLINE' AND [sd].[name] <> 'tempdb'; END /* Find edition */ IF (@IsExpress IS NULL AND CAST(SERVERPROPERTY('Edition') AS VARCHAR(50)) LIKE 'Express%') BEGIN SET @IsExpress = 1; END; ELSE IF (@IsExpress IS NULL) BEGIN; SET @IsExpress = 0; END; /* Find engine edition */ IF (@EngineEdition IS NULL) BEGIN SET @EngineEdition = CAST(SERVERPROPERTY('EditionEdition') AS TINYINT); END; /* Find Version */ IF (@SqlMajorVersion IS NULL) BEGIN; SET @SqlMajorVersion = CAST(SERVERPROPERTY('ProductMajorVersion') AS TINYINT); END; IF (@SqlMinorVersion IS NULL) BEGIN; SET @SqlMinorVersion = CAST(SERVERPROPERTY('ProductMinorVersion') AS SMALLINT); END; /* Validate Version */ IF (@SqlMajorVersion < 11) BEGIN; SET @Msg = 'SQL Server versions below 2012 are not supported, sorry!'; RAISERROR(@Msg, 16, 1); END; /* Check for is_temp value on statistics */ IF 1 = (SELECT 1 FROM [sys].[all_columns] AS [ac] WHERE [ac].[name] = 'is_temporary' AND OBJECT_NAME([ac].[object_id]) = 'all_columns') BEGIN; SET @HasTempStat = 1; END; /* Check for Persisted Sample Percent update */ IF 1 = (SELECT 1 FROM [sys].[all_columns] AS [ac] WHERE [ac].[name] = 'persisted_sample_percent' AND OBJECT_NAME([ac].[object_id]) = 'dm_db_stats_properties') BEGIN; SET @HasPersistedSamplePercent = 1; END; IF (@Verbose = 1) BEGIN; /* Print info */ SET @Msg = 'sp_sizeoptimiser'; RAISERROR(@Msg, 10, 1) WITH NOWAIT; SET @Msg = '------------'; RAISERROR(@Msg, 10, 1) WITH NOWAIT; SET @Msg = CONCAT('Time: ', GETDATE()); RAISERROR(@Msg, 10, 1) WITH NOWAIT; SET @Msg = CONCAT('SQL Major Version: ', @SqlMajorVersion); RAISERROR(@Msg, 10, 1) WITH NOWAIT; SET @Msg = CONCAT('SQL Minor Version: ', @SqlMinorVersion); RAISERROR(@Msg, 10, 1) WITH NOWAIT; SET @Msg = CONCAT('Is Express Edition: ', @IsExpress); RAISERROR(@Msg, 10, 1) WITH NOWAIT; SET @Msg = CONCAT('Is feature "persisted sample percent" available: ', @HasPersistedSamplePercent); RAISERROR(@Msg, 10, 1) WITH NOWAIT; SET @Msg = CONCAT(CHAR(13), CHAR(10)); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; /* Build temp tables */ IF OBJECT_ID(N'tempdb..#results') IS NOT NULL BEGIN; DROP TABLE #results; END; CREATE TABLE #results ([check_num] INT NOT NULL, [check_type] NVARCHAR(50) NOT NULL, [db_name] SYSNAME NOT NULL, [obj_type] SYSNAME NOT NULL, [obj_name] NVARCHAR(400) NOT NULL, [col_name] SYSNAME NULL, [message] NVARCHAR(500) NULL, [ref_link] NVARCHAR(500) NULL); IF OBJECT_ID('tempdb..#DuplicateIndex') IS NOT NULL BEGIN; DROP TABLE #DuplicateIndex; END; CREATE TABLE #DuplicateIndex ([check_type] NVARCHAR(50) NOT NULL ,[obj_type] SYSNAME NOT NULL ,[db_name] SYSNAME NOT NULL ,[obj_name] SYSNAME NOT NULL ,[col_name] SYSNAME NULL ,[message] NVARCHAR(500) NULL ,[object_id] INT NOT NULL ,[index_id] INT NOT NULL); IF OBJECT_ID('tempdb..#OverlappingIndex') IS NOT NULL BEGIN; DROP TABLE #OverlappingIndex; END; CREATE TABLE #OverlappingIndex ([check_type] NVARCHAR(50) NOT NULL ,[obj_type] SYSNAME NOT NULL ,[db_name] SYSNAME NOT NULL ,[obj_name] SYSNAME NOT NULL ,[col_name] SYSNAME NULL ,[message] NVARCHAR(500) NULL ,[object_id] INT NOT NULL ,[index_id] INT NOT NULL); /* Header row */ INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N'Lets do this' ,N'Vroom vroom' ,N'beep boop' ,N'Off to the races' ,N'Ready set go' ,N'Thanks for using' ,@BaseURL; /* Date & Time Data Type Usage */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Date and Time Data Types'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,N''USER_TABLE'' ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME([t].[schema_id])) + ''.'' + QUOTENAME([t].[name]) ,QUOTENAME([c].[name]) ,N''Columns storing date or time should use a temporal specific data type, but this column is using '' + ty.name + ''.'' ,CONCAT(@BaseURL COLLATE database_default, ''time-based-formats'') FROM [sys].[columns] AS [c] INNER JOIN [sys].[tables] AS [t] on [t].[object_id] = [c].[object_id] INNER JOIN [sys].[types] AS [ty] on [ty].[user_type_id] = [c].[user_type_id] WHERE [c].[is_identity] = 0 --exclude identity cols AND [t].[is_ms_shipped] = 0 --exclude sys table AND ([c].[name] LIKE ''%date%'' OR [c].[name] LIKE ''%time%'') AND [c].[name] NOT LIKE ''%UpdatedBy%'' AND [c].[name] NOT LIKE ''%days%'' AND [ty].[name] NOT IN (''datetime'', ''datetime2'', ''datetimeoffset'', ''date'', ''smalldatetime'', ''time'');' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; --Date and Time Data Type Check /* Archaic varchar Lengths (255/256) */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Archaic varchar Lengths'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; WITH archaic AS ( SELECT QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name) AS [obj_name] ,QUOTENAME(c.name) AS [col_name] ,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length / 2 AS varchar(MAX)) + N'' based on requirements?'' AS [message] ,CONCAT(@BaseURL COLLATE database_default, ''arbitrary-varchar-length'') AS [ref_link] FROM sys.columns c INNER JOIN sys.tables as t on t.object_id = c.object_id INNER JOIN sys.types as ty on ty.user_type_id = c.user_type_id WHERE c.is_identity = 0 --exclude identity cols AND t.is_ms_shipped = 0 --exclude sys table AND ty.name = ''NVARCHAR'' AND c.max_length IN (510, 512) UNION SELECT QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name) ,QUOTENAME(c.name) ,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements'' ,CONCAT(@BaseURL COLLATE database_default, ''arbitrary-varchar-length'') FROM sys.columns as c INNER JOIN sys.tables as t on t.object_id = c.object_id INNER JOIN sys.types as ty on ty.user_type_id = c.user_type_id WHERE c.is_identity = 0 --exclude identity cols AND t.is_ms_shipped = 0 --exclude sys table AND ty.name = ''VARCHAR'' AND c.max_length IN (255, 256)) INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,N''USER_TABLE'' ,QUOTENAME(DB_NAME()) ,[obj_name] ,[col_name] ,[message] ,[ref_link] FROM [archaic];' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; --Archaic varchar Lengths /* Unspecified VARCHAR Length */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber,' - Unspecified VARCHAR Length'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + '; WITH UnspecifiedVarChar AS ( SELECT QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name) AS [obj_name] ,QUOTENAME(c.name) AS [col_name] ,N''VARCHAR column without specified length, it should not have a length of '' + CAST (c.max_length AS varchar(10)) + '''' AS [message] ,CONCAT(@BaseURL COLLATE database_default, ''unspecified-varchar-length'') AS [ref_link] FROM sys.columns as c INNER JOIN sys.tables as t on t.object_id = c.object_id INNER JOIN sys.types as ty on ty.user_type_id = c.user_type_id WHERE c.is_identity = 0 --exclude identity cols AND t.is_ms_shipped = 0 --exclude sys table AND ty.name IN (''VARCHAR'', ''NVARCHAR'') AND c.max_length = 1) INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,N''USER_TABLE'' ,QUOTENAME(DB_NAME()) ,[obj_name] ,[col_name] ,[message] ,[ref_link] FROM [UnspecifiedVarChar];' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; --Unspecified VARCHAR Length /* Mad MAX - Varchar(MAX) */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Mad MAX VARCHAR'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,N''USER_TABLE'' ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name) ,QUOTENAME(c.name) ,N''Column is NVARCHAR(MAX) which allows very large row sizes. Consider a character limit.'' ,CONCAT(@BaseURL COLLATE database_default, ''mad-varchar-max'') FROM sys.columns as c INNER JOIN sys.tables as t on t.object_id = c.object_id INNER JOIN sys.types as ty on ty.user_type_id = c.user_type_id WHERE t.is_ms_shipped = 0 --exclude sys table AND ty.[name] = ''nvarchar'' AND c.max_length = -1;' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; --NVARCHAR MAX Check /* NVARCHAR data type in Express */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Use of NVARCHAR (EXPRESS)'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; IF (@IsExpress = 1) BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,N''USER_TABLE'' ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME([o].schema_id)) + ''.'' + QUOTENAME(OBJECT_NAME([o].object_id)) ,QUOTENAME([ac].[name]) ,N''nvarchar columns take 2x the space per char of varchar. Only use if you need Unicode characters.'' ,CONCAT(@BaseURL COLLATE database_default, ''nvarchar-in-express'') FROM [sys].[all_columns] AS [ac] INNER JOIN [sys].[types] AS [t] ON [t].[user_type_id] = [ac].[user_type_id] INNER JOIN [sys].[objects] AS [o] ON [o].object_id = [ac].object_id WHERE [t].[name] = ''NVARCHAR'' AND [o].[is_ms_shipped] = 0' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; --NVARCHAR Use Check ELSE IF (@Verbose = 1) --Skip check BEGIN; RAISERROR(' Skipping check, not Express...', 10, 1) WITH NOWAIT; END; -- Skip check END; --NVARCHAR Use Check /* FLOAT and REAL data types */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg =CONCAT(N'Check ', @CheckNumber, ' - Use of FLOAT/REAL data types'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,[o].[type_desc] ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME([o].[schema_id])) + ''.'' + QUOTENAME([o].[name]) ,QUOTENAME([ac].[name]) ,N''Best practice is to use DECIMAL/NUMERIC instead of '' + UPPER([st].[name]) + '' for non floating point math.'' ,CONCAT(@BaseURL COLLATE database_default, ''float-and-real-data-types'') FROM [sys].[all_columns] AS [ac] INNER JOIN [sys].[objects] AS [o] ON [o].[object_id] = [ac].[object_id] INNER JOIN [sys].[systypes] AS [st] ON [st].[xtype] = [ac].[system_type_id] WHERE [st].[name] IN (''FLOAT'', ''REAL'') AND [o].[type_desc] = ''USER_TABLE'';' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; -- FLOAT/REAL Check /* Deprecated data types (NTEXT, TEXT, IMAGE) */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Deprecated data types'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,[o].[type_desc] ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME(o.schema_id)) + ''.'' + QUOTENAME(o.name) ,QUOTENAME(ac.name) ,N''Deprecated data type in use: '' + st.name + ''.'' ,CONCAT(@BaseURL COLLATE database_default, ''deprecated-data-types'') FROM sys.all_columns AS ac INNER JOIN sys.objects AS o ON o.object_id = ac.object_id INNER JOIN sys.systypes AS st ON st.xtype = ac.system_type_id WHERE st.name IN(''NEXT'', ''TEXT'', ''IMAGE'') AND o.type_desc = ''USER_TABLE'';' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; --Don't use deprecated data types check /* BIGINT for identity values in Express */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - BIGINT used for identity columns (EXPRESS)'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; IF (@IsExpress = 1) BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,N''USER_TABLE'' ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name) ,QUOTENAME(c.name) ,N''BIGINT used on IDENTITY column in SQL Express. If values will never exceed 2,147,483,647 use INT instead.'' ,CONCAT(@BaseURL COLLATE database_default, ''bigint-as-identity'') FROM sys.columns as c INNER JOIN sys.tables as t on t.object_id = c.object_id INNER JOIN sys.types as ty on ty.user_type_id = c.user_type_id WHERE t.is_ms_shipped = 0 --exclude sys table AND ty.name = ''BIGINT'' AND c.is_identity = 1;' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; -- BIGINT for identity Check ELSE IF (@Verbose = 1) --Skip check BEGIN RAISERROR(' Skipping check, not Express...', 10, 1) WITH NOWAIT; END; ----Skip check END; -- BIGINT for identity Check /* Numeric or decimal with 0 scale */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - NUMERIC or DECIMAL with scale of 0'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,[o].[type_desc] ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME(o.schema_id)) + ''.'' + QUOTENAME(o.name) ,QUOTENAME(ac.name) ,N''Column is '' + UPPER(st.name) + ''('' + CAST(ac.precision AS VARCHAR) + '','' + CAST(ac.scale AS VARCHAR) + '')'' + '' . Consider using an INT variety for space reduction since the scale is 0.'' ,CONCAT(@BaseURL COLLATE database_default, ''numeric-or-decimal-0-scale'') FROM sys.objects AS o INNER JOIN sys.all_columns AS ac ON ac.object_id = o.object_id INNER JOIN sys.systypes AS st ON st.xtype = ac.system_type_id WHERE ac.scale = 0 AND ac.precision < 19 AND st.name IN(''DECIMAL'', ''NUMERIC'') AND o.is_ms_shipped = 0;' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; -- Numeric or decimal with 0 scale check /* Enum columns not implemented as foreign key */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Enum columns not implemented as foreign key.'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Data Types'' ,[o].[type_desc] ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME(o.schema_id)) + ''.'' + QUOTENAME(o.name) ,QUOTENAME(ac.name) ,N''Column is potentially an enum that should be a foreign key to a normalized table for data integrity, space savings, and performance.'' ,CONCAT(@BaseURL COLLATE database_default, ''enum-column-not-implemented-as-foreign-key'') FROM sys.objects AS o INNER JOIN sys.all_columns AS ac ON ac.object_id = o.object_id INNER JOIN sys.systypes AS st ON st.xtype = ac.system_type_id WHERE (ac.[name] LIKE ''%Type'' OR ac.[name] LIKE ''%Status'') AND o.is_ms_shipped = 0 AND [o].[type] = ''U'' AND st.[name] IN (''nvarchar'', ''varchar'', ''char'');' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; -- Enum columns not implemented as foreign key /* User DB or model db Growth set past 10GB - ONLY IF EXPRESS */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Data file growth set past 10GB (EXPRESS)'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; IF (@IsExpress = 1) BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''File Growth'' ,N''DATABASE'' ,QUOTENAME(DB_NAME()) ,QUOTENAME(DB_NAME(database_id)) ,NULL ,N''Database file '' + name + '' has a maximum growth set to '' + CASE WHEN max_size = -1 THEN ''Unlimited'' WHEN max_size > 0 THEN CAST((max_size / 1024) * 8 AS VARCHAR(MAX)) END + '', which is over the user database maximum file size of 10GB.'' ,CONCAT(@BaseURL COLLATE database_default, ''database-growth-past-10GB'') FROM sys.master_files mf WHERE (max_size > 1280000 OR max_size = -1) -- greater than 10GB or unlimited AND [mf].[database_id] > 5 AND [mf].[data_space_id] > 0 -- limit doesn''t apply to log files;' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; -- User DB or model db Growth check ELSE IF (@Verbose = 1) --Skip check BEGIN; RAISERROR(' Skipping check, not Express...', 10, 1) WITH NOWAIT; END; END; -- User DB or model db Growth check /* User DB or model db growth set to % */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Data file growth set to percentage.'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; IF (@EngineEdition <> 5) --Not Azure SQL BEGIN INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N'File Growth' ,N'DATABASE' ,QUOTENAME(DB_NAME([sd].[database_id])) ,[mf].[name] ,NULL ,N'Database file '+[mf].[name]+' has growth set to % instead of a fixed amount. This may grow quickly.' ,CONCAT(@BaseURL, 'database-growth-type') FROM [sys].[master_files] AS [mf] INNER JOIN [sys].[databases] AS [sd] ON [sd].[database_id] = [mf].[database_id] INNER JOIN #Databases AS [d] ON [d].[database_name] = [sd].[name] WHERE [mf].[is_percent_growth] = 1 AND [mf].[data_space_id] = 1; --ignore log files END; END; -- User DB or model db growth set to % Check /* Default fill factor (EXPRESS ONLY) */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Non-default fill factor (EXPRESS)'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; IF(@IsExpress = 1) BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Architecture'' ,N''INDEX'' ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME([o].[schema_id])) + ''.'' + QUOTENAME([o].[name]) + ''.'' + QUOTENAME([i].[name]) ,NULL ,N''Non-default fill factor on this index. Not inherently bad, but will increase table size more quickly.'' ,CONCAT(@BaseURL COLLATE database_default, ''default-fill-factor'') FROM [sys].[indexes] AS [i] INNER JOIN [sys].[objects] AS [o] ON [o].[object_id] = [i].[object_id] WHERE [i].[fill_factor] NOT IN(0, 100);' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; -- Non-default fill factor check ELSE IF (@Verbose = 1) --Skip check BEGIN; RAISERROR(' Skipping check, not Express...', 10, 1) WITH NOWAIT; END; END; --Default fill factor /* Number of indexes */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT('Check ', @CheckNumber, ' - Questionable number of indexes'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Architecture'' ,N''INDEX'' ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name) ,NULL ,''There are '' + CAST(COUNT(DISTINCT(i.index_id)) AS VARCHAR) + '' indexes on this table taking up '' + CAST(CAST(SUM(s.[used_page_count]) * 8 / 1024.00 AS DECIMAL(10, 2)) AS VARCHAR) + '' MB of space.'' ,CONCAT(@BaseURL COLLATE database_default, ''number-of-indexes'') FROM sys.indexes AS i INNER JOIN sys.tables AS t ON i.object_id = t.object_id INNER JOIN sys.dm_db_partition_stats AS s ON s.object_id = i.object_id AND s.index_id = i.index_id WHERE t.is_ms_shipped = 0 --exclude sys table AND i.type_desc = ''NONCLUSTERED'' --exclude clustered indexes from count GROUP BY t.name, t.schema_id HAVING COUNT(DISTINCT(i.index_id)) > @IndexNumThreshold;' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@IndexNumThreshold TINYINT, @CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @IndexNumThreshold = @IndexNumThreshold, @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; -- Questionable number of indexes check /* Inefficient Indexes */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Inefficient indexes'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N' USE ? ; BEGIN IF OBJECT_ID(''tempdb..#Indexes'') IS NOT NULL BEGIN; DROP TABLE [#Indexes]; END; IF OBJECT_ID(''tempdb..#IdxChecksum'') IS NOT NULL BEGIN; DROP TABLE [#IdxChecksum]; END; IF OBJECT_ID(''tempdb..#MatchingIdxInclChecksum'') IS NOT NULL BEGIN; DROP TABLE [#MatchingIdxInclChecksum]; END; IF OBJECT_ID(''tempdb..#MatchingIdxChecksum'') IS NOT NULL BEGIN; DROP TABLE [#MatchingIdxChecksum]; END; ' + /* Retrieve all indexes */ + N'SELECT ac.[name] AS [col_name] ,row_number () OVER (PARTITION BY ind.[object_id], ind.index_id ORDER BY indc.index_column_id ) AS row_num ,ind.index_id ,ind.[object_id] ,DENSE_RANK() OVER (ORDER BY ind.[object_id], ind.index_id) AS [index_num] ,indc.is_included_column ,NULL AS [ix_checksum] ,NULL AS [ix_incl_checksum] ,ao.[schema_id] INTO #Indexes FROM sys.indexes as [ind] INNER JOIN sys.index_columns AS [indc] ON [ind].[object_id] = [indc].[object_id] AND ind.index_id = indc.index_id INNER JOIN sys.all_columns as [ac] ON [ac].[column_id] = [indc].[column_id] and indc.[object_id] = ac.[object_id] INNER JOIN sys.all_objects AS [ao] ON [ao].[object_id] = [ac].[object_id] WHERE ao.is_ms_shipped = 0 ORDER BY ind.[object_id]; DECLARE @Counter BIGINT = (SELECT 1); DECLARE @MaxNumIndex BIGINT = (SELECT MAX(index_num) FROM #Indexes); ' + /* Iterate through each index, adding together columns for each */ + N'WHILE @Counter <= @MaxNumIndex BEGIN DECLARE @IndexedColumns NVARCHAR(MAX) = N''''; DECLARE @IndexedColumnsInclude NVARCHAR(MAX) = N''''; ' + /* Add together index columns */ + N'SELECT @IndexedColumns += CAST([col_name] AS SYSNAME) FROM #Indexes WHERE is_included_column = 0 AND index_num = @Counter ORDER BY row_num; ' + /* Add together index + included columns */ + N'SELECT @IndexedColumnsInclude += CAST([col_name] AS SYSNAME) FROM #Indexes WHERE index_num = @Counter ORDER BY row_num; ' + /* Generate a checksum for index columns and index + included columns for each index */ + N'UPDATE #Indexes SET [ix_checksum] = CHECKSUM(@IndexedColumns), [ix_incl_checksum] = CHECKSUM(@IndexedColumnsInclude) WHERE index_num = @Counter; SET @Counter += 1; END; ' + /* Narrow down to one row per index */ + N'SELECT DISTINCT [object_id], index_id, [ix_checksum], [ix_incl_checksum], [schema_id] INTO #IdxChecksum FROM #Indexes; ' + /* Find duplicate indexes */ + N'SELECT COUNT(*) AS [num_dup_indexes], [ix_incl_checksum], [object_id] INTO #MatchingIdxInclChecksum FROM #IdxChecksum GROUP BY [ix_incl_checksum], [object_id] HAVING COUNT(*) > 1; ' + /* Find overlapping indexes with same indexed columns */ + N'SELECT COUNT(*) AS [num_dup_indexes], [ix_checksum], [object_id] INTO #MatchingIdxChecksum FROM #IdxChecksum GROUP BY [ix_checksum], [object_id] HAVING COUNT(*) > 1 INSERT INTO #DuplicateIndex SELECT N''Inefficient Indexes - Duplicate'' AS [check_type] ,N''INDEX'' AS [obj_type] ,QUOTENAME(DB_NAME()) AS [db_name] ,QUOTENAME(SCHEMA_NAME([schema_id])) + ''.'' + QUOTENAME(OBJECT_NAME(ic.[object_id])) + ''.'' + QUOTENAME(i.[name]) AS [obj_name] ,NULL AS [col_name] ,''Indexes in group '' + CAST(DENSE_RANK() over (order by miic.[ix_incl_checksum]) AS VARCHAR(5)) + '' share the same indexed and any included columns.'' AS [message] ,ic.[object_id] ,ic.[index_id] FROM #MatchingIdxInclChecksum AS miic INNER JOIN #IdxChecksum AS ic ON ic.[object_id] = miic.[object_id] AND ic.[ix_incl_checksum] = miic.[ix_incl_checksum] INNER JOIN sys.indexes AS [i] ON [i].[index_id] = ic.index_id AND i.[object_id] = ic.[object_id] INSERT INTO #OverlappingIndex SELECT N''Inefficient Indexes - Overlapping'' AS [check_type] ,N''INDEX'' AS [obj_type] ,QUOTENAME(DB_NAME()) AS [db_name] ,QUOTENAME(SCHEMA_NAME([schema_id])) + ''.'' + QUOTENAME(OBJECT_NAME(ic.[object_id])) + ''.'' + QUOTENAME(i.[name]) AS [obj_name] ,NULL AS [col_name] ,''Indexes in group '' + CAST(DENSE_RANK() OVER (order by mic.[ix_checksum]) AS VARCHAR(5)) + '' share the same indexed columns.'' AS [message] ,ic.[object_id] ,ic.[index_id] FROM #MatchingIdxChecksum AS mic INNER JOIN #IdxChecksum AS ic ON ic.[object_id] = mic.[object_id] AND ic.[ix_checksum] = mic.[ix_checksum] INNER JOIN sys.indexes AS [i] ON [i].[index_id] = ic.index_id AND i.[object_id] = ic.[object_id] ' + /* Dont include any indexes that are already identified as 100% duplicates */ + N'WHERE NOT EXISTS (SELECT * FROM #DuplicateIndex AS [di] WHERE [di].[object_id] = ic.[object_id] AND di.index_id = ic.index_id); END'; DECLARE [DB_Cursor] CURSOR LOCAL FAST_FORWARD FOR SELECT QUOTENAME([database_name]) FROM #Databases; OPEN [DB_Cursor]; FETCH NEXT FROM [DB_Cursor] INTO @DbName; /* Run index query for each database */ WHILE @@FETCH_STATUS = 0 BEGIN; SET @TempCheckSQL = REPLACE(@CheckSQL, N'?', @DbName); EXEC sp_executesql @TempCheckSQL; FETCH NEXT FROM [DB_Cursor] INTO @DbName; END; CLOSE [DB_Cursor]; DEALLOCATE [DB_Cursor]; /* Duplicate Indexes */ INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,[check_type] ,[obj_type] ,[db_name] ,[obj_name] ,[col_name] ,[message] ,CONCAT(@BaseURL,'inefficient-indexes') FROM #DuplicateIndex; /* Overlapping Indexes */ INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,[check_type] ,[obj_type] ,[db_name] ,[obj_name] ,[col_name] ,[message] ,CONCAT(@BaseURL,'inefficient-indexes') FROM #OverlappingIndex; END; -- Inefficient indexes check /* Sparse columns */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Sparse column eligibility'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN; IF OBJECT_ID('tempdb..#SparseTypes') IS NOT NULL BEGIN; DROP TABLE [#SparseTypes]; END; IF OBJECT_ID('tempdb..#Stats') IS NOT NULL BEGIN; DROP TABLE [#Stats]; END; IF OBJECT_ID('tempdb..#StatsHeaderStaging') IS NOT NULL BEGIN; DROP TABLE [#StatsHeaderStaging]; END; IF OBJECT_ID('tempdb..#StatHistogramStaging') IS NOT NULL BEGIN; DROP TABLE [#StatHistogramStaging]; END; CREATE TABLE #SparseTypes ( [ID] INT IDENTITY(1,1) NOT NULL, [name] VARCHAR(20), [user_type_id] INT, [scale] TINYINT NULL, [precision] TINYINT NOT NULL, [threshold_null_perc] TINYINT NOT NULL); CREATE CLUSTERED INDEX cidx_#sparsetypes ON #SparseTypes([ID]); /* Reference values for when it makes sense to use the sparse feature based on 40% minimum space savings including if those recommendations change based on scale / precision. Conservative estimates are used when a column is in between the high and low values in the table. https://docs.microsoft.com/en-us/sql/relational-databases/tables/use-sparse-columns?view=sql-server-2017#estimated-space-savings-by-data-type */ INSERT INTO #SparseTypes ([name], [user_type_id], [scale], [precision], [threshold_null_perc]) VALUES ('BIT',104, 0,0, 98), ('TINYINT',48, 0,0, 86), ('SMALLINT',52, 0,0, 76), ('INT',56, 0,0, 64), ('BIGINT',127, 0,0, 52), ('REAL',59, 0,0, 64), ('FLOAT',62, 0,0, 52), ('SMALLMONEY',122, 0,0, 64), ('MONEY',60, 0,0, 52), ('SMALLDATETIME',58, 0,0, 64), ('DATETIME',61, 0,0, 52), ('UNIQUEIDENTIFIER',36, 0,0, 43), ('DATE',40, 0,0, 69), ('DATETIME2',42, 0,0, 57), ('DATETIME2',42, 7,0, 52), ('TIME',41, 0,0, 69), ('TIME',41, 7,0, 60), ('DATETIMEOFFSET',43, 0,0, 52), ('DATETIMEOFFSET',43, 7,0, 49), ('VARCHAR',167, 0,0, 60), ('CHAR',175, 0,0, 60), ('NVARCHAR',231, 0,0, 60), ('NCHAR',239, 0,0, 60), ('VARBINARY',165, 0,0, 60), ('BINARY',173, 0,0, 60), ('XML',241, 0,0, 60), ('HIERARCHYID',128, 0,0, 60), ('DECIMAL', 106, NULL, 1, 60), ('DECIMAL', 106, NULL, 38, 42), ('NUMERIC', 108, NULL, 1, 60), ('NUMERIC', 108, NULL, 38, 42); --For STAT_HEADER data CREATE TABLE #StatsHeaderStaging ( [name] SYSNAME ,[updated] DATETIME2(0) ,[rows] BIGINT ,[rows_sampled] BIGINT ,[steps] INT ,[density] DECIMAL(6,3) ,[average_key_length] REAL ,[string_index] VARCHAR(10) ,[filter_expression] NVARCHAR(MAX) ,[unfiltered_rows] BIGINT); --Check for extra persisted sample percent column IF @HasPersistedSamplePercent = 1 BEGIN; ALTER TABLE #StatsHeaderStaging ADD [persisted_sample_percent] INT; END; --For HISTOGRAM data CREATE TABLE #StatHistogramStaging ( [range_hi_key] NVARCHAR(MAX) ,[range_rows] BIGINT ,[eq_rows] DECIMAL(38,2) ,[distinct_range_rows] BIGINT ,[avg_range_rows] BIGINT); --For combined DBCC stat data (SHOW_STAT + HISTOGRAM) CREATE TABLE #Stats ( [stats_id] INT IDENTITY(1,1) ,[db_name] SYSNAME ,[stat_name] SYSNAME ,[stat_updated] DATETIME2(0) ,[rows] BIGINT ,[rows_sampled] BIGINT ,[schema_name] SYSNAME ,[table_name] SYSNAME NULL ,[col_name] SYSNAME NULL ,[eq_rows] BIGINT NULL ,[null_perc] AS CAST([eq_rows] AS DECIMAL (38,2)) / NULLIF([rows], 0) * 100 ,[threshold_null_perc] SMALLINT); CREATE CLUSTERED INDEX cidx_#stats ON #Stats([stats_id]); SET @CheckSQL = N' USE ?; BEGIN DECLARE @schemaName SYSNAME ,@tableName SYSNAME ,@statName SYSNAME ,@colName SYSNAME ,@threshold_null_perc SMALLINT; DECLARE @DBCCSQL NVARCHAR(MAX) = N''''; DECLARE @DBCCStatSQL NVARCHAR(MAX) = N''''; DECLARE @DBCCHistSQL NVARCHAR(MAX) = N''''; DECLARE [DBCC_Cursor] CURSOR LOCAL FAST_FORWARD FOR SELECT DISTINCT sch.name AS [schema_name] ,t.name AS [table_name] ,s.name AS [stat_name] ,ac.name AS [col_name] ,threshold_null_perc FROM [sys].[stats] AS [s] INNER JOIN [sys].[stats_columns] AS [sc] on sc.stats_id = s.stats_id INNER JOIN [sys].[tables] AS [t] on t.object_id = s.object_id INNER JOIN [sys].[schemas] AS [sch] on sch.schema_id = t.schema_id INNER JOIN [sys].[all_columns] AS [ac] on ac.column_id = sc.column_id AND [ac].[object_id] = [t].[object_id] AND [ac].[object_id] = [sc].[object_id] INNER JOIN [sys].[types] AS [typ] ON [typ].[user_type_id] = [ac].[user_type_id] INNER JOIN [sys].[indexes] AS [i] ON [i].[object_id] = [t].[object_id] ' + /* Special considerations for variable length data types */ + N'INNER JOIN [#SparseTypes] AS [st] ON [st].[user_type_id] = [typ].[user_type_id] AND (typ.name NOT IN (''DECIMAL'', ''NUMERIC'', ''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'')) OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND st.precision = ac.precision AND st.precision = 1) OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND ac.precision > 1 AND st.precision = 38) OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND st.scale = ac.scale AND st.scale = 0) OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND ac.scale > 0 AND st.scale = 7) WHERE [sc].[stats_column_id] = 1 AND [s].[has_filter] = 0 AND [s].[no_recompute] = 0 AND [ac].[is_nullable] = 1 AND NOT EXISTS (SELECT 1 -- Compressed tables not compatible with sparse cols FROM [sys].[partitions] AS [p] WHERE [p].[object_id] = [i].[object_id] AND [p].[data_compression] > 0) '; IF @HasTempStat = 1 BEGIN; SET @CheckSQL = @CheckSQL + N'AND [s].[is_temporary] = 0; '; END; SET @CheckSQL = @CheckSQL + N' OPEN [DBCC_Cursor]; FETCH NEXT FROM [DBCC_Cursor] INTO @schemaName, @tableName, @statName, @colName, @threshold_null_perc; WHILE @@FETCH_STATUS = 0 BEGIN; DECLARE @SchemaTableName SYSNAME = QUOTENAME(@schemaName) + ''.'' + QUOTENAME(@tableName); ' + /* Build DBCC statistics queries */ + N'SET @DBCCSQL = N''DBCC SHOW_STATISTICS(@SchemaTableName, @statName)''; SET @DBCCStatSQL = @DBCCSQL + '' WITH STAT_HEADER, NO_INFOMSGS;''; SET @DBCCHistSQL = @DBCCSQL + '' WITH HISTOGRAM, NO_INFOMSGS;''; ' + /* Stat Header temp table */ + N'INSERT INTO #StatsHeaderStaging EXEC sp_executesql @DBCCStatSQL ,N''@SchemaTableName SYSNAME, @statName SYSNAME'' ,@SchemaTableName = @SchemaTableName ,@statName = @statName; ' + /* Histogram temp table */ + N'INSERT INTO #StatHistogramStaging EXEC sp_executesql @DBCCHistSQL ,N''@SchemaTableName SYSNAME, @statName SYSNAME'' ,@SchemaTableName = @SchemaTableName ,@statName = @statName; INSERT INTO #Stats SELECT DB_NAME() ,[head].[name] ,[head].[updated] ,[head].[rows] ,[head].[rows_sampled] ,@schemaName ,@tableName ,@colName ,[hist].[eq_rows] ,@threshold_null_perc FROM #StatsHeaderStaging head CROSS APPLY #StatHistogramStaging hist WHERE hist.range_hi_key IS NULL AND hist.eq_rows > 0 AND head.unfiltered_rows > 0 AND head.rows > 1000; TRUNCATE TABLE #StatsHeaderStaging; TRUNCATE TABLE #StatHistogramStaging; FETCH NEXT FROM DBCC_Cursor INTO @schemaName, @tableName, @statName, @colName, @threshold_null_perc; END; CLOSE [DBCC_Cursor]; DEALLOCATE [DBCC_Cursor]; END;'; DECLARE [DB_Cursor] CURSOR LOCAL FAST_FORWARD FOR SELECT QUOTENAME([database_name]) FROM #Databases; OPEN [DB_Cursor]; FETCH NEXT FROM [DB_Cursor] INTO @DbName; /* Run stat query for each database */ WHILE @@FETCH_STATUS = 0 BEGIN; SET @TempCheckSQL = REPLACE(@CheckSQL, N'?', @DbName); EXEC sp_executesql @TempCheckSQL; FETCH NEXT FROM [DB_Cursor] INTO @DbName; END; CLOSE [DB_Cursor]; DEALLOCATE [DB_Cursor]; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N'Architecture' ,N'USER_TABLE' ,QUOTENAME([db_name]) ,QUOTENAME([schema_name]) + '.' + QUOTENAME([table_name]) ,QUOTENAME([col_name]) ,N'Candidate for converting to a space-saving sparse column based on NULL distribution of more than ' + CAST([threshold_null_perc] AS VARCHAR(3))+ ' percent.' ,CONCAT(@BaseURL, 'sparse-columns') FROM #Stats WHERE [null_perc] >= [threshold_null_perc]; END; -- Sparse column check /* Heap Tables */ SET @CheckNumber = @CheckNumber + 1; IF (@Verbose = 1) BEGIN; SET @Msg = CONCAT(N'Check ', @CheckNumber, ' - Heap Tables'); RAISERROR(@Msg, 10, 1) WITH NOWAIT; END; BEGIN SET @CheckSQL = N''; SELECT @CheckSQL = @CheckSQL + N'USE ' + QUOTENAME([database_name]) + N'; INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link]) SELECT @CheckNumber ,N''Architecture'' ,N''INDEX'' ,QUOTENAME(DB_NAME()) ,QUOTENAME(SCHEMA_NAME([t].[schema_id])) + ''.'' + QUOTENAME([t].[name]) ,NULL ,N''Heap tables can result in massive fragmentation and have additional indexing overhead.'' ,CONCAT(@BaseURL COLLATE database_default, ''heap-tables'') FROM [sys].[tables] AS [t] INNER JOIN [sys].[indexes] AS [i] ON [i].[object_id] = [t].[object_id] WHERE [i].[type] = 0' FROM #Databases; EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL; END; --Heap Tables /* Wrap it up */ SELECT [check_num] ,[check_type] ,[db_name] ,[obj_type] ,[obj_name] ,[col_name] ,[message] ,[ref_link] FROM #results ORDER BY [check_num], [check_type], [db_name], [obj_type], [obj_name], [col_name], [message]; END TRY BEGIN CATCH; BEGIN; DECLARE @ErrorNumber INT = ERROR_NUMBER(); DECLARE @ErrorLine INT = ERROR_LINE(); DECLARE @ErrorMessage NVARCHAR(4000) = ERROR_MESSAGE(); DECLARE @ErrorSeverity INT = ERROR_SEVERITY(); DECLARE @ErrorState INT = ERROR_STATE(); RAISERROR(@ErrorMessage, @ErrorSeverity, @ErrorState) WITH NOWAIT; SET @msg = CONCAT('Actual error number: ', @ErrorNumber); RAISERROR(@msg, 16, 1); SET @msg = CONCAT('Actual line number: ', @ErrorLine); RAISERROR(@msg, 16, 1); SET @msg = CONCAT('Check number: ', @CheckNumber); RAISERROR(@msg, 16, 1); END; END CATCH; END; GO EXEC sys.sp_addextendedproperty @name=N'Description', @value=N'Recommends space saving and corrective data type measures based on SQL Server database schemas. Documentation at https://expresssql.lowlydba.com' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'Description', @value=N'Required table type for sp_sizeoptimiser.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'TYPE',@level1name=N'SizeOptimiserTableType'; GO EXEC sys.sp_addextendedproperty @name=N'@SqlMajorVersion', @value=N'Used for unit testing purposes only.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'@SqlMinorVersion', @value=N'Used for unit testing purposes only.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'@IndexNumThreshold', @value=N'Number of indexes to classify a table as having too many indexes on it. Default value is 10.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'@IncludeDatabases', @value=N'Which databases to run the script on in the form of a user defined table type. If not supplied, all accessible user databases are targeted. Cannot be used in conjunction with @ExcludeDatabases.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'@ExcludeDatabases', @value=N'Which databases to exclude in the form of a user defined table type. Cannot be used in conjunction with @IncludeDatabases.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'@IncludeSysDatabases', @value=N'Whether or not to include system databases in the script''s analysis. Default is 0.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'@IncludeSSRSDatabases', @value=N'Whether or not to include SQL Server Reporting Services databases in the script''s analysis. Default is 0.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'@Verbose', @value=N'Whether or not to print additional information during the script run. Default is 0.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO EXEC sys.sp_addextendedproperty @name=N'@IsExpress', @value=N'Used for unit testing purposes only.' , @level0type=N'SCHEMA',@level0name=N'dbo', @level1type=N'PROCEDURE',@level1name=N'sp_sizeoptimiser'; GO