package com.amazonaws.iot.accountauditconfiguration; import com.google.common.collect.ImmutableMap; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; import org.mockito.ArgumentCaptor; import org.mockito.Mock; import org.mockito.junit.jupiter.MockitoExtension; import software.amazon.awssdk.services.iot.model.InternalFailureException; import software.amazon.awssdk.services.iot.model.IotRequest; import software.amazon.awssdk.services.iot.model.ThrottlingException; import software.amazon.awssdk.services.iot.model.UpdateAccountAuditConfigurationRequest; import software.amazon.cloudformation.proxy.AmazonWebServicesClientProxy; import software.amazon.cloudformation.proxy.HandlerErrorCode; import software.amazon.cloudformation.proxy.Logger; import software.amazon.cloudformation.proxy.OperationStatus; import software.amazon.cloudformation.proxy.ProgressEvent; import software.amazon.cloudformation.proxy.ResourceHandlerRequest; import java.util.Map; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.ACCOUNT_ID; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.AUDIT_CHECK_CONFIGURATIONS_V2_CFN; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.AUDIT_NOTIFICATION_TARGET_V2_CFN; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.AUDIT_NOTIFICATION_TARGET_V2_IOT; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.DESCRIBE_REQUEST; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.DESCRIBE_RESPONSE_V1_STATE; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.DESCRIBE_RESPONSE_ZERO_STATE; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.DISABLED_IOT; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.ENABLED_IOT; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.ROLE_ARN; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.createCfnRequest; import static com.amazonaws.iot.accountauditconfiguration.TestConstants.getNotificationBuilderIot; import static org.assertj.core.api.Assertions.assertThat; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; @ExtendWith(MockitoExtension.class) public class UpdateHandlerTest { private static final Map CHECK_CONFIGURATION_FROM_EXPECTED_UPDATE_REQUEST = ImmutableMap.of( // enable 1, disable 1 "LOGGING_DISABLED_CHECK", ENABLED_IOT, "DEVICE_CERTIFICATE_EXPIRING_CHECK", ENABLED_IOT, "CA_CERTIFICATE_EXPIRING_CHECK", DISABLED_IOT, "CONFLICTING_CLIENT_IDS_CHECK", DISABLED_IOT, "CA_CERTIFICATE_KEY_QUALITY_CHECK", DISABLED_IOT); private static final ResourceModel MODEL_V2 = ResourceModel.builder() .accountId(ACCOUNT_ID) .auditCheckConfigurations(AUDIT_CHECK_CONFIGURATIONS_V2_CFN) .auditNotificationTargetConfigurations(AUDIT_NOTIFICATION_TARGET_V2_CFN) .roleArn(ROLE_ARN + "_v2") .build(); @Mock private AmazonWebServicesClientProxy proxy; @Mock private Logger logger; private UpdateHandler handler; @BeforeEach public void setup() { handler = new UpdateHandler(); } @Test public void handleRequest_DescribeShowsDifferentConfig_UpdateOverwritesEverything() { ResourceHandlerRequest cfnRequest = createCfnRequest(MODEL_V2); when(proxy.injectCredentialsAndInvokeV2(any(), any())) .thenReturn(DESCRIBE_RESPONSE_V1_STATE); ProgressEvent response = handler.handleRequest(proxy, cfnRequest, null, logger); UpdateAccountAuditConfigurationRequest expectedUpdateRequest = UpdateAccountAuditConfigurationRequest.builder() .auditCheckConfigurations(CHECK_CONFIGURATION_FROM_EXPECTED_UPDATE_REQUEST) .auditNotificationTargetConfigurationsWithStrings(AUDIT_NOTIFICATION_TARGET_V2_IOT) .roleArn(ROLE_ARN + "_v2") .build(); ArgumentCaptor iotRequestCaptor = ArgumentCaptor.forClass(IotRequest.class); verify(proxy, times(2)).injectCredentialsAndInvokeV2(iotRequestCaptor.capture(), any()); assertThat(iotRequestCaptor.getAllValues().get(1)).isEqualTo(expectedUpdateRequest); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.SUCCESS); assertThat(response.getCallbackContext()).isNull(); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isEqualTo(cfnRequest.getDesiredResourceState()); assertThat(response.getResourceModels()).isNull(); assertThat(response.getMessage()).isNull(); assertThat(response.getErrorCode()).isNull(); } @Test public void handleRequest_DescribeShowsZeroState_ExpectNFE() { ResourceHandlerRequest cfnRequest = createCfnRequest(MODEL_V2); when(proxy.injectCredentialsAndInvokeV2(any(), any())) .thenReturn(DESCRIBE_RESPONSE_ZERO_STATE); ProgressEvent actualResult = handler.handleRequest(proxy, cfnRequest, null, logger); ProgressEvent expectedResult = ProgressEvent.failed( MODEL_V2, null, HandlerErrorCode.NotFound, "The configuration for your account has not been set up or was deleted."); assertThat(actualResult).isEqualTo(expectedResult); } @Test public void buildNotificationTargetConfigurationsForUpdate_NoneInModel_DisabledInResult() { ResourceModel model = ResourceModel.builder() .auditNotificationTargetConfigurations(null) .build(); Map expectedResult = ImmutableMap.of("SNS", getNotificationBuilderIot().enabled(false).build()); Map actualResult = handler.buildNotificationTargetConfigurationsForUpdate(model); assertThat(actualResult).isEqualTo(expectedResult); } @Test public void handleRequest_ExceptionFromDescribe_Translated() { ResourceHandlerRequest cfnRequest = createCfnRequest(MODEL_V2); when(proxy.injectCredentialsAndInvokeV2(eq(DESCRIBE_REQUEST), any())) .thenThrow(InternalFailureException.builder().build()); ProgressEvent progressEvent = handler.handleRequest(proxy, cfnRequest, null, logger); assertThat(progressEvent.getErrorCode()).isEqualTo(HandlerErrorCode.InternalFailure); } @Test public void handleRequest_ExceptionFromUpdate_Translated() { ResourceHandlerRequest cfnRequest = createCfnRequest(MODEL_V2); when(proxy.injectCredentialsAndInvokeV2(any(), any())) .thenReturn(DESCRIBE_RESPONSE_V1_STATE) .thenThrow(ThrottlingException.builder().build()); ProgressEvent progressEvent = handler.handleRequest(proxy, cfnRequest, null, logger); assertThat(progressEvent.getErrorCode()).isEqualTo(HandlerErrorCode.Throttling); } }