package software.amazon.rds.dbproxyendpoint; import static org.assertj.core.api.Assertions.assertThat; import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.doThrow; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.verify; import static software.amazon.rds.dbproxyendpoint.Constants.AVAILABLE_ENDPOINT_STATE; import java.util.function.Function; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; import org.mockito.ArgumentCaptor; import org.mockito.ArgumentMatchers; import org.mockito.Mock; import org.mockito.junit.jupiter.MockitoExtension; import com.amazonaws.AmazonWebServiceResult; import com.amazonaws.ResponseMetadata; import com.amazonaws.services.rds.model.AddTagsToResourceRequest; import com.amazonaws.services.rds.model.DBProxyEndpoint; import com.amazonaws.services.rds.model.DBProxyEndpointNotFoundException; import com.amazonaws.services.rds.model.ModifyDBProxyEndpointRequest; import com.amazonaws.services.rds.model.ModifyDBProxyEndpointResult; import com.amazonaws.services.rds.model.RemoveTagsFromResourceRequest; import com.amazonaws.services.rds.model.Tag; import com.google.common.collect.ImmutableList; import software.amazon.cloudformation.proxy.AmazonWebServicesClientProxy; import software.amazon.cloudformation.proxy.HandlerErrorCode; import software.amazon.cloudformation.proxy.Logger; import software.amazon.cloudformation.proxy.OperationStatus; import software.amazon.cloudformation.proxy.ProgressEvent; import software.amazon.cloudformation.proxy.ResourceHandlerRequest; @ExtendWith(MockitoExtension.class) public class UpdateHandlerTest { @Mock private AmazonWebServicesClientProxy proxy; @Mock private Logger logger; @BeforeEach public void setup() { proxy = mock(AmazonWebServicesClientProxy.class); logger = mock(Logger.class); } @Test public void handleRequest_SimpleSuccess() { DBProxyEndpoint dbProxyEndpoint = new DBProxyEndpoint().withStatus(AVAILABLE_ENDPOINT_STATE); final CallbackContext context = CallbackContext.builder() .proxyEndpoint(dbProxyEndpoint) .stabilizationRetriesRemaining(1) .tagsRegistered(true) .tagsDeregistered(true) .build(); final UpdateHandler handler = new UpdateHandler(); final ResourceModel model = ResourceModel.builder().build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(model) .previousResourceState(model) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.SUCCESS); assertThat(response.getCallbackContext()).isNull(); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isEqualTo(request.getDesiredResourceState()); assertThat(response.getResourceModels()).isNull(); assertThat(response.getMessage()).isNull(); assertThat(response.getErrorCode()).isNull(); } @Test public void testModifyNonExistProxyEndpoint() { DBProxyEndpointNotFoundException exception = new DBProxyEndpointNotFoundException(TestConstants.NOT_FOUND_ERROR_MESSAGE); doThrow(exception).when(proxy).injectCredentialsAndInvoke(any(ModifyDBProxyEndpointRequest.class), ArgumentMatchers.>>any()); final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .build(); final UpdateHandler handler = new UpdateHandler(); final ResourceModel desiredModel = ResourceModel.builder().build(); final ResourceModel oldModel = ResourceModel.builder().build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.FAILED); assertThat(response.getCallbackContext()).isNull(); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isNull(); assertThat(response.getResourceModels()).isNull(); assertThat(response.getMessage()).isEqualTo(exception.getMessage()); assertThat(response.getErrorCode()).isEqualTo(HandlerErrorCode.NotFound); } @Test public void testModifyDBProxyNameCreateOnlyProperty() { final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .build(); final UpdateHandler handler = new UpdateHandler(); final ResourceModel desiredModel = ResourceModel.builder().dBProxyName("new-proxy-name").build(); final ResourceModel oldModel = ResourceModel.builder().dBProxyName("old-proxy-name").build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.FAILED); assertThat(response.getCallbackContext()).isNull(); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isNull(); assertThat(response.getResourceModels()).isNull(); assertThat(response.getMessage()).contains(UpdateHandler.DB_PROXY_NAME_CREATE_ONLY_MESSAGE); assertThat(response.getErrorCode()).isEqualTo(HandlerErrorCode.NotUpdatable); } @Test public void testModifyDBProxyEndpointNameCreateOnlyProperty() { final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .build(); final UpdateHandler handler = new UpdateHandler(); final ResourceModel desiredModel = ResourceModel.builder().dBProxyEndpointName("new-proxy-endpoint-name").build(); final ResourceModel oldModel = ResourceModel.builder().dBProxyEndpointName("old-proxy-endpoint-name").build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.FAILED); assertThat(response.getCallbackContext()).isNull(); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isNull(); assertThat(response.getResourceModels()).isNull(); assertThat(response.getMessage()).contains(UpdateHandler.DB_PROXY_ENDPOINT_NAME_CREATE_ONLY_MESSAGE); assertThat(response.getErrorCode()).isEqualTo(HandlerErrorCode.NotUpdatable); } @Test public void testModifyVpcSubnetIdsCreateOnlyProperty() { final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .build(); final UpdateHandler handler = new UpdateHandler(); final ResourceModel desiredModel = ResourceModel.builder().vpcSubnetIds(ImmutableList.of("subnet-1")).build(); final ResourceModel oldModel = ResourceModel.builder().vpcSubnetIds(ImmutableList.of("subnet-1", "subnet-2")).build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.FAILED); assertThat(response.getCallbackContext()).isNull(); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isNull(); assertThat(response.getResourceModels()).isNull(); assertThat(response.getMessage()).contains(UpdateHandler.VPC_SUBNET_ID_CREATE_ONLY_MESSAGE); assertThat(response.getErrorCode()).isEqualTo(HandlerErrorCode.NotUpdatable); } @Test public void testModifyTargetRoleCreateOnlyProperty() { final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .build(); final UpdateHandler handler = new UpdateHandler(); final ResourceModel desiredModel = ResourceModel.builder().targetRole("READ_ONLY").build(); final ResourceModel oldModel = ResourceModel.builder().targetRole("READ_WRITE").build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.FAILED); assertThat(response.getCallbackContext()).isNull(); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isNull(); assertThat(response.getResourceModels()).isNull(); assertThat(response.getMessage()).contains(UpdateHandler.TARGET_ROLE_CREATE_ONLY_MESSAGE); assertThat(response.getErrorCode()).isEqualTo(HandlerErrorCode.NotUpdatable); } @Test public void testModifyProxyEndpoint() { DBProxyEndpoint dbProxyEndpoint = new DBProxyEndpoint().withStatus(AVAILABLE_ENDPOINT_STATE); doReturn(new ModifyDBProxyEndpointResult().withDBProxyEndpoint(dbProxyEndpoint)) .when(proxy).injectCredentialsAndInvoke(any(ModifyDBProxyEndpointRequest.class), ArgumentMatchers.>>any()); final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .build(); final UpdateHandler handler = new UpdateHandler(); final ResourceModel desiredModel = ResourceModel.builder().build(); final ResourceModel oldModel = ResourceModel.builder().build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final CallbackContext desiredOutputContext = CallbackContext.builder() .stabilizationRetriesRemaining(Constants.NUMBER_OF_STATE_POLL_RETRIES) .proxyEndpoint(dbProxyEndpoint) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.IN_PROGRESS); assertThat(response.getCallbackContext()).isEqualToComparingFieldByField(desiredOutputContext); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isEqualTo(request.getDesiredResourceState()); assertThat(response.getMessage()).isNull(); assertThat(response.getErrorCode()).isNull(); } @Test public void testDeregisterTags() { DBProxyEndpoint dbProxyEndpoint = new DBProxyEndpoint().withStatus(AVAILABLE_ENDPOINT_STATE); final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .proxyEndpoint(dbProxyEndpoint) .build(); final UpdateHandler handler = new UpdateHandler(); TagFormat tag1 = new TagFormat(); tag1.setKey("key1"); tag1.setValue("value1"); TagFormat tag2 = new TagFormat(); tag2.setKey("key2"); tag2.setValue("value2"); final ResourceModel desiredModel = ResourceModel.builder().build(); final ResourceModel oldModel = ResourceModel.builder().tags(ImmutableList.of(tag1, tag2)).build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final CallbackContext desiredOutputContext = CallbackContext.builder() .proxyEndpoint(dbProxyEndpoint) .stabilizationRetriesRemaining(Constants.NUMBER_OF_STATE_POLL_RETRIES) .tagsDeregistered(true) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.IN_PROGRESS); assertThat(response.getCallbackContext()).isEqualToComparingFieldByField(desiredOutputContext); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isEqualTo(request.getDesiredResourceState()); assertThat(response.getMessage()).isNull(); assertThat(response.getErrorCode()).isNull(); ArgumentCaptor captor = ArgumentCaptor.forClass(RemoveTagsFromResourceRequest.class); verify(proxy).injectCredentialsAndInvoke(captor.capture(), ArgumentMatchers.>>any()); RemoveTagsFromResourceRequest removeTagsRequest = captor.getValue(); assertThat(removeTagsRequest.getTagKeys().size()).isEqualTo(2); } @Test public void testRegisterTags() { DBProxyEndpoint dbProxyEndpoint = new DBProxyEndpoint().withStatus(AVAILABLE_ENDPOINT_STATE); final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .tagsDeregistered(true) .proxyEndpoint(dbProxyEndpoint) .build(); final UpdateHandler handler = new UpdateHandler(); TagFormat tag1 = new TagFormat(); tag1.setKey("key1"); tag1.setValue("value1"); TagFormat tag2 = new TagFormat(); tag2.setKey("key2"); tag2.setValue("value2"); final ResourceModel desiredModel = ResourceModel.builder().tags(ImmutableList.of(tag1, tag2)).build(); final ResourceModel oldModel = ResourceModel.builder().build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final CallbackContext desiredOutputContext = CallbackContext.builder() .stabilizationRetriesRemaining(Constants.NUMBER_OF_STATE_POLL_RETRIES) .tagsDeregistered(true) .proxyEndpoint(dbProxyEndpoint) .tagsRegistered(true) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.IN_PROGRESS); assertThat(response.getCallbackContext()).isEqualToComparingFieldByField(desiredOutputContext); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isEqualTo(request.getDesiredResourceState()); assertThat(response.getMessage()).isNull(); assertThat(response.getErrorCode()).isNull(); ArgumentCaptor captor = ArgumentCaptor.forClass(AddTagsToResourceRequest.class); verify(proxy).injectCredentialsAndInvoke(captor.capture(), ArgumentMatchers.>>any()); AddTagsToResourceRequest removeTagsRequest = captor.getValue(); assertThat(removeTagsRequest.getTags().size()).isEqualTo(2); } @Test public void testChangedTagValue_deregister() { DBProxyEndpoint dbProxyEndpoint = new DBProxyEndpoint().withStatus(AVAILABLE_ENDPOINT_STATE); final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .proxyEndpoint(dbProxyEndpoint) .build(); final UpdateHandler handler = new UpdateHandler(); String sharedKey = "key1"; TagFormat tag1 = new TagFormat(); tag1.setKey(sharedKey); tag1.setValue("value1"); TagFormat tag2 = new TagFormat(); tag2.setKey("key2"); tag2.setValue("value2"); TagFormat tag3 = new TagFormat(); tag3.setKey(sharedKey); tag3.setValue("value3"); final ResourceModel desiredModel = ResourceModel.builder().tags(ImmutableList.of(tag3, tag2)).build(); final ResourceModel oldModel = ResourceModel.builder().tags(ImmutableList.of(tag1, tag2)).build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final CallbackContext desiredOutputContext = CallbackContext.builder() .stabilizationRetriesRemaining(Constants.NUMBER_OF_STATE_POLL_RETRIES) .tagsDeregistered(true) .proxyEndpoint(dbProxyEndpoint) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.IN_PROGRESS); assertThat(response.getCallbackContext()).isEqualToComparingFieldByField(desiredOutputContext); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isEqualTo(request.getDesiredResourceState()); assertThat(response.getMessage()).isNull(); assertThat(response.getErrorCode()).isNull(); ArgumentCaptor captor = ArgumentCaptor.forClass(RemoveTagsFromResourceRequest.class); verify(proxy).injectCredentialsAndInvoke(captor.capture(), ArgumentMatchers.>>any()); RemoveTagsFromResourceRequest removeTagsRequest = captor.getValue(); assertThat(removeTagsRequest.getTagKeys().size()).isEqualTo(1); assertThat(removeTagsRequest.getTagKeys().get(0)).isEqualTo(sharedKey); } @Test public void testChangedTagValue_Register() { DBProxyEndpoint dbProxyEndpoint = new DBProxyEndpoint().withStatus(AVAILABLE_ENDPOINT_STATE); final CallbackContext context = CallbackContext.builder() .stabilizationRetriesRemaining(1) .tagsDeregistered(true) .proxyEndpoint(dbProxyEndpoint) .build(); final UpdateHandler handler = new UpdateHandler(); String sharedKey = "key1"; String newValue = "value3"; TagFormat tag1 = new TagFormat(); tag1.setKey(sharedKey); tag1.setValue("value1"); TagFormat tag2 = new TagFormat(); tag2.setKey("key2"); tag2.setValue("value2"); TagFormat tag3 = new TagFormat(); tag3.setKey(sharedKey); tag3.setValue(newValue); final ResourceModel desiredModel = ResourceModel.builder().tags(ImmutableList.of(tag3, tag2)).build(); final ResourceModel oldModel = ResourceModel.builder().tags(ImmutableList.of(tag1, tag2)).build(); final ResourceHandlerRequest request = ResourceHandlerRequest.builder() .desiredResourceState(desiredModel) .previousResourceState(oldModel) .build(); final CallbackContext desiredOutputContext = CallbackContext.builder() .stabilizationRetriesRemaining(Constants.NUMBER_OF_STATE_POLL_RETRIES) .tagsDeregistered(true) .tagsRegistered(true) .proxyEndpoint(dbProxyEndpoint) .build(); final ProgressEvent response = handler.handleRequest(proxy, request, context, logger); assertThat(response).isNotNull(); assertThat(response.getStatus()).isEqualTo(OperationStatus.IN_PROGRESS); assertThat(response.getCallbackContext()).isEqualToComparingFieldByField(desiredOutputContext); assertThat(response.getCallbackDelaySeconds()).isEqualTo(0); assertThat(response.getResourceModel()).isEqualTo(request.getDesiredResourceState()); assertThat(response.getMessage()).isNull(); assertThat(response.getErrorCode()).isNull(); ArgumentCaptor captor = ArgumentCaptor.forClass(AddTagsToResourceRequest.class); verify(proxy).injectCredentialsAndInvoke(captor.capture(), ArgumentMatchers.>>any()); AddTagsToResourceRequest addTagRequest = captor.getValue(); assertThat(addTagRequest.getTags().size()).isEqualTo(1); Tag addedTag = addTagRequest.getTags().get(0); assertThat(addedTag.getKey()).isEqualTo(sharedKey); assertThat(addedTag.getValue()).isEqualTo(newValue); } }