package software.amazon.s3outposts.bucketpolicy; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; import org.mockito.Mock; import org.mockito.junit.jupiter.MockitoExtension; import software.amazon.awssdk.services.s3control.S3ControlClient; import software.amazon.awssdk.services.s3control.model.DeleteBucketPolicyRequest; import software.amazon.awssdk.services.s3control.model.DeleteBucketPolicyResponse; import software.amazon.awssdk.services.s3control.model.GetBucketPolicyRequest; import software.amazon.awssdk.services.s3control.model.GetBucketPolicyResponse; import software.amazon.cloudformation.proxy.*; import java.time.Duration; import static org.assertj.core.api.Assertions.assertThat; import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.*; @ExtendWith(MockitoExtension.class) public class DeleteHandlerTest extends AbstractTestBase { private DeleteHandler handler; private ResourceHandlerRequest request; @Mock private AmazonWebServicesClientProxy proxy; @Mock private ProxyClient proxyClient; @Mock S3ControlClient sdkClient; @BeforeEach public void setup() { handler = new DeleteHandler(); proxy = new AmazonWebServicesClientProxy(logger, MOCK_CREDENTIALS, () -> Duration.ofSeconds(600).toMillis()); sdkClient = mock(S3ControlClient.class); proxyClient = MOCK_PROXY(proxy, sdkClient); } @AfterEach public void tear_down() { verifyNoMoreInteractions(sdkClient); } /** * Happy Path */ @Test public void handleRequest_SimpleSuccess() { request = ResourceHandlerRequest.builder() .desiredResourceState(ONLY_BUCKET_MODEL) .build(); final GetBucketPolicyResponse getBucketPolicyResponse = GetBucketPolicyResponse.builder() .policy(BUCKET_POLICY) .build(); when(proxyClient.client().getBucketPolicy(any(GetBucketPolicyRequest.class))) .thenReturn(getBucketPolicyResponse); final DeleteBucketPolicyResponse deleteResponse = DeleteBucketPolicyResponse.builder().build(); when(proxyClient.client().deleteBucketPolicy(any(DeleteBucketPolicyRequest.class))).thenReturn(deleteResponse); final ProgressEvent progress = handler.handleRequest(proxy, request, new CallbackContext(), proxyClient, logger); assertThat(progress).isNotNull(); assertThat(progress.getStatus()).isEqualTo(OperationStatus.SUCCESS); assertThat(progress.getCallbackDelaySeconds()).isEqualTo(0); assertThat(progress.getResourceModel()).isNull(); assertThat(progress.getResourceModels()).isNull(); assertThat(progress.getMessage()).isNull(); assertThat(progress.getErrorCode()).isNull(); verify(proxyClient.client()).getBucketPolicy(any(GetBucketPolicyRequest.class)); verify(proxyClient.client()).deleteBucketPolicy(any(DeleteBucketPolicyRequest.class)); verify(sdkClient, atLeastOnce()).serviceName(); } /** * Validation Error: No BucketARN provided */ @Test public void handleRequest_NoBucket() { request = ResourceHandlerRequest.builder() .build(); final ProgressEvent progress = handler.handleRequest(proxy, request, new CallbackContext(), proxyClient, logger); assertThat(progress).isNotNull(); assertThat(progress.getStatus()).isEqualTo(OperationStatus.FAILED); assertThat(progress.getErrorCode()).isEqualTo(HandlerErrorCode.InvalidRequest); assertThat(progress.getMessage()).isEqualTo("Bucket ARN is required."); assertThat(progress.getCallbackContext()).isEqualTo(new CallbackContext()); assertThat(progress.getCallbackDelaySeconds()).isEqualTo(0); assertThat(progress.getResourceModels()).isNull(); } /** * Error - GetBucketPolicy returns NO_SUCH_BUCKET_POLICY */ @Test public void handleRequest_Error_GetBucketPolicy() { request = ResourceHandlerRequest.builder() .desiredResourceState(ONLY_BUCKET_MODEL) .build(); when(proxyClient.client().getBucketPolicy(any(GetBucketPolicyRequest.class))) .thenThrow(constructS3ControlException("NoSuchBucketPolicy")); final ProgressEvent progress = handler.handleRequest(proxy, request, new CallbackContext(), proxyClient, logger); assertThat(progress).isNotNull(); assertThat(progress.getStatus()).isEqualTo(OperationStatus.FAILED); assertThat(progress.getErrorCode()).isEqualTo(HandlerErrorCode.NotFound); assertThat(progress.getMessage()).isEqualTo("Bucket Policy does not exist."); assertThat(progress.getCallbackContext()).isEqualToComparingOnlyGivenFields(new CallbackContext()); assertThat(progress.getCallbackDelaySeconds()).isEqualTo(0); assertThat(progress.getResourceModels()).isNull(); verify(proxyClient.client()).getBucketPolicy(any(GetBucketPolicyRequest.class)); verify(sdkClient, atLeastOnce()).serviceName(); } }