""" Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. """ import re from cfnlint import CloudFormationLintRule from cfnlint import RuleMatch class SubNeeded(CloudFormationLintRule): """Check if a substitution string exists without a substitution function""" id = 'E1029' shortdesc = 'Sub is required if a variable is used in a string' description = 'If a substitution variable exists in a string but isn\'t wrapped with the Fn::Sub function the deployment will fail.' source_url = 'https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-sub.html' tags = ['functions', 'sub'] # Free-form text properties to exclude from this rule # content is part of AWS::CloudFormation::Init excludes = ['UserData', 'ZipFile', 'Condition', 'AWS::CloudFormation::Init', 'CloudWatchAlarmDefinition'] api_excludes = ['Uri', 'Body'] # IAM Policy has special variables that don't require !Sub, Check for these # https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_variables.html # https://docs.aws.amazon.com/iot/latest/developerguide/basic-policy-variables.html # https://docs.aws.amazon.com/iot/latest/developerguide/thing-policy-variables.html resource_excludes = ['${aws:CurrentTime}', '${aws:EpochTime}', '${aws:TokenIssueTime}', '${aws:principaltype}', '${aws:SecureTransport}', '${aws:SourceIp}', '${aws:UserAgent}', '${aws:userid}', '${aws:username}', '${ec2:SourceInstanceARN}', '${iot:Connection.Thing.ThingName}', '${iot:Connection.Thing.ThingTypeName}', '${iot:Connection.Thing.IsAttached}', '${iot:ClientId}'] def _match_values(self, searchRegex, cfnelem, path): """Recursively search for values matching the searchRegex""" values = [] if isinstance(cfnelem, dict): for key in cfnelem: pathprop = path[:] pathprop.append(key) values.extend(self._match_values(searchRegex, cfnelem[key], pathprop)) elif isinstance(cfnelem, list): for index, item in enumerate(cfnelem): pathprop = path[:] pathprop.append(index) values.extend(self._match_values(searchRegex, item, pathprop)) else: # Leaf node if isinstance(cfnelem, str) and re.match(searchRegex, cfnelem): # Get all variables as seperate paths regex = re.compile(r'(\$\{.*?\.?.*?})') for variable in re.findall(regex, cfnelem): values.append(path + [variable]) return values def match_values(self, searchRegex, cfn): """ Search for values in all parts of the templates that match the searchRegex """ results = [] results.extend(self._match_values(searchRegex, cfn.template, [])) # Globals are removed during a transform. They need to be checked manually results.extend(self._match_values(searchRegex, cfn.template.get('Globals', {}), [])) return results def _api_exceptions(self, value): """ Key value exceptions """ parameter_search = re.compile(r'^\$\{stageVariables\..*\}$') return re.match(parameter_search, value) def match(self, cfn): """Basic Rule Matching""" matches = [] # Generic regex to match a string containing at least one ${parameter} parameter_search = re.compile(r'^.*(\$\{.*\}.*(\$\{.*\}.*)*)$') # Get a list of paths to every leaf node string containing at least one ${parameter} parameter_string_paths = self.match_values(parameter_search, cfn) # We want to search all of the paths to check if each one contains an 'Fn::Sub' for parameter_string_path in parameter_string_paths: # Exxclude the special IAM variables variable = parameter_string_path[-1] if 'Resource' in parameter_string_path: if variable in self.resource_excludes: continue # Exclude literals (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-sub.html) if variable.startswith('${!'): continue found_sub = False # Does the path contain an 'Fn::Sub'? for step in parameter_string_path: if step in self.api_excludes: if self._api_exceptions(parameter_string_path[-1]): found_sub = True elif step == 'Fn::Sub' or step in self.excludes: found_sub = True # If we didn't find an 'Fn::Sub' it means a string containing a ${parameter} may not be evaluated correctly if not found_sub: # Remove the last item (the variable) to prevent multiple errors on 1 line errors path = parameter_string_path[:-1] message = 'Found an embedded parameter outside of an "Fn::Sub" at {}'.format('/'.join(map(str, path))) matches.append(RuleMatch(path, message)) return matches